yuseok89 commented on code in PR #73922:
URL: https://github.com/apache/airflow/pull/73922#discussion_r4141298102
##########
providers/apache/beam/src/airflow/providers/apache/beam/operators/beam.py:
##########
@@ -142,6 +142,8 @@ def __get_dataflow_pipeline_options(
pipeline_options["impersonateServiceAccount"] =
self.dataflow_config.impersonation_chain
pipeline_options["project"] = self.dataflow_config.project_id
pipeline_options["region"] = self.dataflow_config.location
+ if self.dataflow_config.max_num_workers is not None:
+ pipeline_options["max_num_workers"] =
self.dataflow_config.max_num_workers
Review Comment:
The Java operator passes keys as-is, so this reaches Java as
`--max_num_workers`, but Java reads `--maxNumWorkers` and would likely reject
unknown flags. Would `maxNumWorkers` work here, like
`impersonateServiceAccount`? `convert_camel_to_snake` would still give Python
and Go `max_num_workers`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
