Kaap10 opened a new pull request, #73939:
URL: https://github.com/apache/airflow/pull/73939
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
Follow-up to #73753 based on reviewer feedback from @henry3260:
1. **Docstring Accuracy in `test_task_state_store.py`**:
- `test_set_nonexistent_dag_run_returns_404`: Clarified that the 404
response originates from scope validation (`_validate_scope`), not `set()`.
- `test_set_nonexistent_task_id_returns_404`: Fixed docstring typo
(`doesn not` -> `does not`) and clarified scope validation origin.
2. **Detail Assertions**:
- Added explicit assertions on `response.json()["detail"]` for both scope
validation tests.
3. **Domain Exception Coverage for PUT**:
- Added `test_set_task_state_store_domain_error_returns_404` using
`autospec=True` on `MetastoreBackend.set` to verify exception translation
parity with `PATCH`.
related: #73753
---
##### Was generative AI tooling used to co-author this PR?
- [X] Yes - Antigravity
Generated-by: Antigravity following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
