Andrushika commented on code in PR #73943:
URL: https://github.com/apache/airflow/pull/73943#discussion_r4142847183
##########
airflow-core/src/airflow/ui/public/i18n/locales/zh-CN/dag.json:
##########
@@ -101,7 +101,11 @@
},
"settings": "日志设置",
"viewInExternal": "在 {{name}} 中查看日志（重试 {{attempt}}）",
- "warning": "WARNING"
+ "warning": "WARNING",
+ "tryNotStarted": "此次重试尚未开始。",
+ "viewFailedTry": "查看第 {{tryNumber}} 次失败重试的日志",
+ "viewPreviousTry": "查看上一次重试（第 {{tryNumber}} 次）的日志",
+ "waitingToRetry": "第 {{tryNumber}} 次重试正在等待执行。"
Review Comment:
These four use 重试 for "try", but the rest of the zh-CN locale uses 尝试
(`tryNumber` 尝试次数, `maxTries` 最大尝试次数, `taskTryPlaceholder` 任务尝试).
`stateReasonSummary` in this PR uses 尝试 too.
For example: with `retries=1`, try 1 fails and the task goes to
`up_for_retry` with try 2 pending. The log tab then shows "第 2 次重试正在等待执行", but
this is the first retry. The button says "查看第 1 次失败重试的日志", but try 1 was the
first run, not a retry. And for a task that has not run yet, "此次重试尚未开始" shows
up when there is no retry at all.
Maybe something like this:
```suggestion
"tryNotStarted": "此次尝试尚未开始。",
"viewFailedTry": "查看第 {{tryNumber}} 次失败尝试的日志",
"viewPreviousTry": "查看上一次尝试（第 {{tryNumber}} 次）的日志",
"waitingToRetry": "第 {{tryNumber}} 次尝试正在等待重试。"
```
##########
airflow-core/src/airflow/ui/public/i18n/locales/zh-CN/common.json:
##########
@@ -558,5 +568,12 @@
"tooltip": "按 {{hotkey}} 切换换行",
"unwrap": "不换行",
"wrap": "换行"
+ },
+ "dagBundle_one": "Dag 套件包",
Review Comment:
This key replaces `dagBundles.bundle_one` / `bundle_other` in `browse.json`.
`en` no longer has those two, but zh-CN still keeps them (`browse.json` lines
15-16).
For example: `breeze ui check-translation-completeness --language zh-CN` on
this branch shows 0 missing keys, but lists both under "Unused keys".
Could you remove them in this PR? They are in the same `dagBundles` block
you already edit.
##########
airflow-core/src/airflow/ui/public/i18n/locales/zh-CN/common.json:
##########
@@ -295,7 +295,11 @@
"helper": "未单独设置布局方向的 Dag 和资源图表所使用的方向。",
"label": "默认图表方向"
},
- "title": "图表"
+ "title": "图表",
+ "taskGroupsExpanded": {
Review Comment:
Nit: the new keys are added at the end of each block, so the order no longer
follows `en` (here `taskGroupsExpanded` comes after `title`). Before this PR,
the zh-CN order matched `en` in all five of these files. The JSON hook does not
sort keys, so this only helps when diffing against `en`.
##########
airflow-core/src/airflow/ui/public/i18n/locales/zh-CN/dashboard.json:
##########
@@ -35,7 +35,22 @@
"scheduler": "调度器",
"status": "状态",
"triggerer": "触发器",
- "unhealthy": "健康状态异常"
+ "unhealthy": "健康状态异常",
+ "degraded": "降级",
Review Comment:
Nit, and I am not fully sure: 降级 often reads as a planned service downgrade.
Here the badge means some bundles or teams have no running instance, so 部分可用
might be clearer. Same for 宕机 on line 44, where 不可用 is a bit more formal.
Happy to leave this to a native zh-CN speaker.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
