jason810496 commented on code in PR #73441:
URL: https://github.com/apache/airflow/pull/73441#discussion_r4144224673


##########
airflow-core/docs/authoring-and-scheduling/language-sdks/typescript.rst:
##########
@@ -336,6 +336,29 @@ Pass ``{ prefixGroupId: false }`` to keep the ids declared 
in a group as written
 does in Python; they then have to be unique across the Dag. A group id is made 
of letters, digits, dashes and
 underscores, and is at most 200 characters.
 
+Serialization
+~~~~~~~~~~~~~
+
+A native Dag serializes into the same Dag JSON a Python Dag produces, so the 
scheduler reads it
+without knowing which language declared it.
+
+``schedule`` accepts what maps to a stock timetable: unset, ``@once``, 
``@continuous``, or a cron
+expression. A cron preset such as ``@daily`` is recorded as the expression it 
stands for. Anything
+else names a Python object a TypeScript bundle cannot point at, and is 
rejected.
+
+Every task of a native Dag runs on the Node coordinator, so it needs the queue 
the deployment routes
+there. Set it once on the Dag and each task inherits it:
+
+.. code-block:: typescript
+
+    const dag = new Dag("ts_etl", { schedule: "@daily", queue: "typescript" });

Review Comment:
   The "queue" for any SDKs can be anything depends on the users' `[sdk] 
queue_to_coordinator` config.
   Yeah, we _could_ introduce the concept of "global default queue for each 
SDKs", but it might need more design and can be follow-up on post release.
   
   TP and I discussed a bit on this topic yesterday but we haven't settled down 
the final direction yet.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to