Lee-W commented on code in PR #73903:
URL: https://github.com/apache/airflow/pull/73903#discussion_r4144847172
##########
task-sdk/tests/task_sdk/execution_time/test_task_runner.py:
##########
@@ -788,6 +787,68 @@ def
test_task_span_no_parent_when_no_context_carrier(make_ti_context):
assert finished[0].parent is None
+UNSAMPLED_TRACE_ID = 0x4BF92F3577B34DA6A3CE929D0E0E4736
+UNSAMPLED_CARRIER = {"traceparent":
f"00-{UNSAMPLED_TRACE_ID:032x}-00f067aa0ba902b7-00"}
+
+
+def _startup_with_carrier(make_ti_context, carrier: dict[str, str]) ->
StartupDetails:
Review Comment:
```suggestion
def _make_startup_with_carrier(make_ti_context, carrier: dict[str, str]) ->
StartupDetails:
```
##########
task-sdk/tests/task_sdk/execution_time/test_task_runner.py:
##########
@@ -788,6 +787,68 @@ def
test_task_span_no_parent_when_no_context_carrier(make_ti_context):
assert finished[0].parent is None
+UNSAMPLED_TRACE_ID = 0x4BF92F3577B34DA6A3CE929D0E0E4736
Review Comment:
i guess this is just some random uuid?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
