bingqin2 commented on PR #72953: URL: https://github.com/apache/airflow/pull/72953#issuecomment-5915139282
Thanks for the review, @molcay. The helper is gone in favour of `tenacity.retry` (details in the threads), and the 28 time-span unit tests pass, including the retry, give-up and single-attempt cases for both downloads and uploads. On system tests: I don't have a GCP project, so I haven't run `example_gcs_transform_timespan.py`. That test covers the happy path, where the default of one attempt keeps today's behaviour; the retry path only runs on transient `GoogleCloudError`s, which the unit tests simulate. If your team can run it on the system-test dashboard, that would confirm the real transfer path. If you have a moment, #72954 in the same provider (the IdP extra parameters that never reach the token request) has been waiting for a first review since the 11th. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
