kaxil commented on PR #73923:
URL: https://github.com/apache/airflow/pull/73923#issuecomment-5939766409
Closing this. The task-group check doesn't run on real Dags: nested groups
are serialized as `(TASK_GROUP, {...})` tuples, and `_validate_task_group_ids`
only recurses into children that are dicts with a `children` key, so only the
hand-built dict in the test reaches it. The new check also applies core's
`validate_key` to every Dag, Python ones included. That rejects ids containing
`..`, which the Task SDK accepts, so Dags that parse today would become import
errors. The description and tests don't cover either case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
