kaxil commented on PR #73533: URL: https://github.com/apache/airflow/pull/73533#issuecomment-5940874500
Closing this. The new `if key not in self.running: return` guard runs before `delete_pod`, but adopted completed pods never enter `self.running`: `_adopt_completed_pods` only queues them in `self.completed` with `state="completed"`. With this change those pods are never deleted or patched, and the existing `test_sync_processes_completed_pods_once`, which expects three `delete_pod` calls for keys that aren't in `running`, would fail. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
