aaron-y-chen commented on code in PR #71576:
URL: https://github.com/apache/airflow/pull/71576#discussion_r4162836485
##########
chart/values.schema.json:
##########
@@ -7124,6 +7124,17 @@
"type": "boolean",
"default": true
},
+ "strategy": {
+ "description": "Update strategy for the StatsD
Deployment.",
+ "type": "object",
Review Comment:
Should we validate this like `triggerer.strategy` and
`dagProcessor.strategy`?
https://github.com/apache/airflow/blob/413ae46a045365ba1c8d285ae0932674f4c69e83/chart/values.schema.json#L4038-L4045
https://github.com/apache/airflow/blob/413ae46a045365ba1c8d285ae0932674f4c69e83/chart/values.schema.json#L4681-L4688
Without the `$ref`, a typo (e.g. `rollingupdate`) passes schema validation
and is silently ignored.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
