Shubham-Padkonde commented on code in PR #73780:
URL: https://github.com/apache/airflow/pull/73780#discussion_r4163339943
##########
providers/smtp/tests/unit/smtp/hooks/test_smtp.py:
##########
@@ -374,6 +374,28 @@ def test_send_mime_nossl(self, mock_smtp, mock_smtp_ssl):
assert not mock_smtp_ssl.called
mock_smtp.assert_called_once_with(host=SMTP_HOST, port=NONSSL_PORT,
timeout=DEFAULT_TIMEOUT)
+ @pytest.mark.parametrize(
+ ("query", "expected_ssl", "expected_starttls"),
+ [
+ ("", True, True),
+ ("disable_ssl=true&disable_tls=true", False, False),
+ ("disable_ssl=false&disable_tls=false", True, True),
+ ("disable_ssl=False&disable_tls=0", True, True),
+ ("disable_ssl=1&disable_tls=false", False, True),
Review Comment:
Thanks for the review! I've aligned the true values with to_boolean (on, t,
true, y, yes, 1) and added tests for those plus a typo (ture), which keeps
SSL/TLS enabled. I also dropped the FTPHook comparison from the description,
since FTPHook doesn't parse passive.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
