pierrejeambrun commented on PR #74019: URL: https://github.com/apache/airflow/pull/74019#issuecomment-5948895836
Updated, we are now capturing 'negative' for sharing urls. > How is our source of truth chain supposed to work here and then with https://github.com/apache/airflow/pull/74021? Resolution order is url -> localstorage -> global setting (added in the following PR). > We only say when match anywhere is on. Do we also want an explicit match anywhere is off? Because otherwise we're going to localStorage or the user default. Yes indeed. Addressed in last commit. https://github.com/user-attachments/assets/39105648-fb92-449e-8e1f-93dddef9baf2 > If this is in url params, we should completely remove the localStorage option and only have global config + url param Localstorage is still usefull when navigating from within the application (because all those internal redirection links won't be providing those query params in the url). Typically: - Use the navbar to navigate to the 'dags' page. Activate the advanced search. (url is updated and sharable) - Navigate away from this page - Come back to the dag page by clicking on the 'nav bar' - If we remove the local storage, this will fall back to the user 'default' while the person explicitely set the `match everywherre` for this particular filter. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
