Jonghyun-An opened a new pull request, #74131:
URL: https://github.com/apache/airflow/pull/74131

   An XCom entry can disappear between loading the list and fetching its value. 
The value request then returns 404, but `XComEntry` still tries to format 
`undefined` and throws `Cannot read properties of undefined (reading 'match')`. 
This replaces the entire list with an error page.
   
   Handle the query error in the affected value cell so the other entries 
remain visible and can still be copied. The cell shows the status and message 
on one line, with long messages truncated. Clicking the summary opens the full 
error in a popover without increasing the row height. Failed refetches also 
replace the stale value and its copy button with the error.
   
   ### Testing
   
   - `pnpm test src/pages/XCom/XComEntry.test.tsx` in Breeze: 6 passed; all 6 
fail against the original component. Covers 404/403/500, a failed refetch, 
structured 422 details, and a network error.
   - File-scoped pre-commit and manual checks passed, including ESLint, 
Prettier, TypeScript, and the production UI build.
   - Checked the compiled UI in Chromium with mocked responses: error and 
healthy rows both stay at 57px. Verified long-message truncation, scrollable 
details, Enter/Space activation, Escape dismissal with focus restored, and a 
390px viewport. No rendering errors.
   
   ### Screenshots
   
   | Before | After |
   | --- | --- |
   | ![XCom list replaced by a rendering 
error](https://airflow-xcom-review-a8661354.markajh.chatgpt.site/assets/before-7ac5ea4daf2e.png)
 | ![Single-line error with the remaining XCom entries 
visible](https://airflow-xcom-review-a8661354.markajh.chatgpt.site/assets/after-7ac5ea4daf2e.png)
 |
   
   [Expanded error 
details](https://airflow-xcom-review-a8661354.markajh.chatgpt.site/assets/details-7ac5ea4daf2e.png)
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [X] Yes — GPT-6.1-Sol
   
   Generated-by: GPT-6.1-Sol following [the 
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to