FrankYang0529 commented on code in PR #72057:
URL: https://github.com/apache/airflow/pull/72057#discussion_r4172289011


##########
providers/edge3/src/airflow/providers/edge3/worker_api/routes/jobs.py:
##########
@@ -44,11 +45,19 @@
 
 jobs_router = AirflowRouter(tags=["Jobs"], prefix="/jobs")
 
+# ``ExecuteCallback`` is also a valid Dag id, so checking ``dag_id`` alone 
would mistake that Dag's
+# tasks for callbacks. ``EdgeExecutor.queue_workload()`` gives a callback this 
whole identity.
+_IS_CALLBACK_JOB = and_(

Review Comment:
   Moved the SQL expression into `types.py` as `build_callback_job_filter()`. 
The filter uses `CALLBACK_JOB_TRY_NUMBER`, `CALLBACK_JOB_MAP_INDEX`, and a new 
`CALLBACK_JOB_RUN_ID_PREFIX`. Thanks for the suggestion.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to