dabla opened a new pull request, #74161:
URL: https://github.com/apache/airflow/pull/74161

   > [!IMPORTANT]
   > **Depends on #74147, which needs to be merged first.** That PR adds 
`get_async_extra_dejson()` to the common.compat provider, which this PR uses; 
the branch is stacked on it, so the diff shows #74147's commit until it is 
merged and this branch is rebased. The common-compat requirement uses the `# 
use next version` marker for the release that ships the helper.
   
   `KiotaRequestAdapterHook.get_async_conn()` deserializes the raw connection 
extra with `json.loads(connection.extra)`, to avoid `extra_dejson`, whose 
secret masking sends to the supervisor synchronously and fails on the event 
loop (#54350, #55179). That works, but skips masking the extra's individual 
values (e.g. proxy credentials, client secrets in the extra).
   
   This switches the async path to `get_async_extra_dejson()` from 
common.compat (#74147): `Connection.aextra_dejson()` on Airflow 3.3.2+ (masks 
asynchronously, #71890), `extra_dejson` in a worker thread on older versions. 
`_build_request_adapter()` now receives the deserialized extra instead of 
parsing it; the deprecated sync `get_conn()` keeps its current `json.loads` and 
is unchanged.
   
   Tests: a new test asserts `get_async_conn()` reads the extra through 
`get_async_extra_dejson()`; the existing msgraph hook/operator/sensor/trigger 
tests pass unchanged.
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [X] Yes — Claude Opus 5.5
   
   Generated-by: Claude Opus 5.5 following [the 
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to