SEPURI-SAI-KRISHNA commented on code in PR #74171:
URL: https://github.com/apache/airflow/pull/74171#discussion_r4176062057
##########
providers/amazon/tests/unit/amazon/aws/operators/test_ecs.py:
##########
@@ -191,6 +191,20 @@ def
test_get_task_log_fetcher_uses_region_name_when_awslogs_region_not_set(self)
assert fetcher.hook.region_name == "region"
+ def test_get_task_log_fetcher_uses_operator_aws_configuration(self):
+ self.set_up_operator(
+ awslogs_group="awslogs-group",
+ awslogs_stream_prefix="prefix",
+ region_name="region",
+ verify="/path/to/ca-bundle.pem",
+ botocore_config={"read_timeout": 10},
+ )
+
+ fetcher = self.ecs._get_task_log_fetcher()
+
+ assert fetcher.hook._verify == "/path/to/ca-bundle.pem"
+ assert fetcher.hook._config.read_timeout == 10
Review Comment:
Covered in the reply on `test_batch.py`. This one mocks
`airflow.providers.amazon.aws.operators.ecs.AwsTaskLogFetcher` and asserts the
two arguments this change adds, with no hook internals involved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
