potiuk commented on PR #74007:
URL: https://github.com/apache/airflow/pull/74007#issuecomment-5977513165
@amoghrajesh, could you take another look? This re-applies #70681, and
@olayiwola-gbenga's commits address both issues from your post-merge review:
- a bad `[secrets] backends_order` no longer breaks the CLI, because the
backend list is now loaded on first use;
- `backends_order` is served from `/ui/config`, so there's no 403 with the
default `expose_config = False`.
I pushed two commits on top:
- f3cbe6c0d7 folds in my unmerged follow-up #73852:
- the server search path is defined once in the shared module, and the
`check-secrets-search-path-sync` hook is removed (it had been passing without
checking anything);
- `version_added` is now 3.4.0;
- the docs examples show the defaults instead of an empty value, which
Airflow rejects at startup;
- the newsfragment is now `feature`.
- a73fa811ff shows the order on the Connections page as well as the
Variables page, as asked in the dev@ discussion.
On the consensus question: I've revived the [dev@
thread](https://lists.apache.org/thread/xtzho20rzy7fq4h7lh897xm4qxj7ltb5) with
a summary and an answer to Elad's concern. This shouldn't be merged before that
settles.
---
Drafted-by: Claude Code (Opus 5.5); reviewed by @potiuk before posting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
