atharvaajmera opened a new pull request, #74192:
URL: https://github.com/apache/airflow/pull/74192

   ## Summary
   
   The triggerer tells migration, user action and shutdown apart only by 
`asyncio.CancelledError` propagating out of `trigger.run()`. The `except 
asyncio.CancelledError` handlers in `DataprocSubmitTrigger.run()`, 
`DataprocSubmitJobDirectTrigger.run()` and `DataprocClusterTrigger.run()` 
performed cleanup (cancel the job/cluster when `safe_to_cancel()`) but never 
re-raised, so a transient triggerer stall followed by trigger migration 
produced `Trigger exited without sending an event. Dependent tasks will be 
failed.` for every hosted deferred task instead of a transparent failover.
   
   This is the same bug shape fixed for `BigQueryInsertJobTrigger` in #63730: 
add the missing bare `raise` after cleanup so `cleanup_finished_triggers()` 
takes the expected cancelled path. `DataprocBatchTrigger`, 
`DataprocDeleteClusterTrigger` and `DataprocOperationTrigger` are unaffected 
(no `CancelledError` handler, and `except Exception` does not catch 
`CancelledError`).
   
   The cancellation tests now require `CancelledError` instead of also 
accepting `StopAsyncIteration`, and the cluster not-safe test actually injects 
cancellation (it previously completed before cancelling).
   
   closes: #74087
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [X] Yes — Muse Spark
   
   Generated-by: Muse Spark following [the 
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to