zozo123 commented on code in PR #74173: URL: https://github.com/apache/airflow/pull/74173#discussion_r4178937137
########## scripts/ci/docker_data_root_snapshot.sh: ########## @@ -0,0 +1,154 @@ +#!/usr/bin/env bash +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +# Moves the CI image between jobs as a copy of the Docker data directory that holds it, so a job +# restores it with one extraction instead of `docker image load` unpacking and checksumming every +# layer again. +# +# docker_data_root_snapshot.sh create SNAPSHOT_FILE +# Keeps only the CI image in the daemon and writes its image store to SNAPSHOT_FILE, plus +# SNAPSHOT_FILE.meta naming the daemon that wrote it and the image. +# docker_data_root_snapshot.sh restore SNAPSHOT_FILE +# Restores the image. Incompatible snapshots leave the daemon untouched. Failed +# materialization cleans partial image state and restarts Docker for the normal stash path. +set -euo pipefail + +DATA_ROOT="/var/lib/docker" +DAEMON_STOPPED=false +RESTORE_IN_PROGRESS=false + +function cleanup_daemon() { + local result=$? + trap - EXIT + if [[ "${RESTORE_IN_PROGRESS}" == true ]]; then + stop_daemon + remove_image_store + start_daemon + elif [[ "${DAEMON_STOPPED}" == true ]]; then + start_daemon + fi + exit "${result}" +} +trap cleanup_daemon EXIT + +function check_supported_daemon() { + local daemon=$1 + local _ driver root + read -r _ driver _ root <<< "${daemon}" + if [[ "${driver}" != overlay2 || "${root}" != "${DATA_ROOT}" ]]; then Review Comment: Fixed in the latest push. Unsupported Docker storage and daemon-fingerprint mismatches now emit ::warning:: annotations before falling back. The producer also warns and skips snapshot creation on unsupported storage, before pruning or archiving. Regression tests verify the restore warnings. Python and Actions CodeQL passed; the full CI matrix is still running. AI-assisted: Codex (GPT-6), reviewed by the PR author. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
