olegkachur-e commented on PR #73181:
URL: https://github.com/apache/airflow/pull/73181#issuecomment-5991370289

   > Thanks, this looks right. `google.cloud.bigtable.Client` builds the admin 
gRPC channel from `client_options.api_endpoint` only and falls back to 
`bigtableadmin.googleapis.com` otherwise. It ignores `universe_domain`, so the 
generic `ClientOptions(universe_domain=...)` from `GoogleBaseHook` does not 
reach a non-default universe for Bigtable. Forcing `bigtableadmin.<universe>` 
matches the GAPIC endpoint template, and the default-universe path is unchanged.
   > 
   > I rebased onto current `main` and pushed one small follow-up commit 
(`4418d68271`) with a few nits I'd otherwise have asked for — each is explained 
inline. Merging once CI is green.
   > 
   > Drafted-by: Claude Code (Opus 5); reviewed by @potiuk before posting
   
   Awesome! Thank you for the review and help 👍


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to