pierrejeambrun commented on code in PR #73805:
URL: https://github.com/apache/airflow/pull/73805#discussion_r4183105447
##########
airflow-core/src/airflow/ui/src/pages/DagsList/AssetSchedule.tsx:
##########
@@ -118,13 +118,17 @@ export const AssetSchedule = ({ assetExpression, dagId,
timetablePartitioned, ti
0,
)
: pendingEvents.length;
+ // `events` only carries the assets the caller may read, so the total and the
+ // layout branches below come from `scheduling_asset_count` instead — the
schedule
+ // a Dag shows should not change with who is looking at it.
+ const schedulingAssetCount = nextRun?.scheduling_asset_count ??
nextRunEvents.length;
Review Comment:
Why the fallback ? (fallback is wrong I believe, wait for
`scheduling_asset_count` or something is wrong.
```suggestion
const schedulingAssetCount = nextRun?.scheduling_asset_count ?? 0
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
