olegkachur-e commented on code in PR #72286:
URL: https://github.com/apache/airflow/pull/72286#discussion_r4184419815
##########
providers/google/src/airflow/providers/google/cloud/hooks/bigquery.py:
##########
@@ -2437,20 +2438,28 @@ async def cancel_job(self, job_id: str, project_id: str
| None, location: str |
self.log.error("Failed to cancel BigQuery job %s: %s", job_id,
str(e))
raise
- # TODO: Convert get_records into an async method
def get_records(
self,
query_results: dict[str, Any],
as_dict: bool = False,
selected_fields: str | list[str] | None = None,
) -> list[Any]:
"""
- Convert a response from BigQuery to records.
+ Convert a response from BigQuery to records (synchronous).
Review Comment:
The re is a special "@deprecated" decorator and the deprecation policy
inside the google provider, please use and follow it, if you want to deprecate
some element.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
