kaxil opened a new pull request, #74273:
URL: https://github.com/apache/airflow/pull/74273

   The fields a provider declares under `conn-fields` in `provider.yaml` were 
grouped in a section titled "Extra Fields" that started collapsed. When the 
setting that defines a connection type lives in `extra` (the model for Pydantic 
AI; account and warehouse for Snowflake), creating that connection showed only 
the optional host and password fields, and the ones that matter sat behind a 
closed accordion. 39 provider packages declare `conn-fields`.
   
   That section is now titled after the connection type ("Pydantic AI Fields", 
"Snowflake Fields") and opens by default alongside Standard Fields. "Extra 
Fields JSON" keeps its name, because it is the raw `extra` editor.
   
   The accordion now renders only once the connection type metadata has loaded, 
and it is keyed on the connection type, so the open-by-default state is applied 
again when the user switches type. Without that gate, an edit dialog opened 
right after page load would mount with the type id in the title ("pydanticai 
Fields"). When the metadata arrived, the section would either stay closed under 
its new title or, if remounted, reset the store holding the saved extras. While 
the metadata is pending, Standard Fields had nothing to show anyway, and the 
type selector already shows a spinner.
   
   Every connection type's provider section now starts open, so the dialog is 
longer for types with many extras, such as Google Cloud (15 fields). Each 
section can still be collapsed.
   
   The English wording changed in meaning, so it moves to a new 
`connectionTypeFields` key and the old `extraFields` key is removed from every 
locale, as the i18n README asks for rephrased strings. Other locales fall back 
to English until translated.
   
   The "Extra Fields" name and the collapsed default go back to the original 
form in #47868. It reused `FlexibleForm`, which needs a section title, and 
named that section after where the values are stored. Only Standard Fields was 
listed in the accordion's `defaultValue`. Collapsing the provider fields was 
never discussed there. The Airflow 2 form rendered provider fields inline with 
the standard ones.
   
   **Before** (new Pydantic AI connection on `main`):
   
   ![Before: Model hidden in a collapsed Extra Fields section](./add_before.png)
   
   **After** (new connection, after switching type from Snowflake to Pydantic 
AI):
   
   ![After: Pydantic AI Fields section open with Model 
visible](./add_after_switch.png)
   
   **After** (editing an existing connection):
   
   ![After: edit form with Pydantic AI Fields open](./edit_after.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to