shahar1 opened a new pull request, #74296:
URL: https://github.com/apache/airflow/pull/74296
related: #73713
Followup to the above, this PR applies the digit grouping in all existing
locales.
<details><summary>AI Summary</summary>
Follow-up to #73713, which grouped digits of numbers the UI renders
directly. Counters interpolated into translated strings (Dag, run and task
counts, import errors, pool slots, deadlines, log search matches, ...) still
render as raw integers, so `12345` shows instead of `12,345` (en), `12.345`
(de) or `12 345` (fr).
This routes every counter placeholder through i18next's built-in `number`
formatter (`{{count}}` → `{{count, number}}`) in all locales, so each language
gets its own grouping without custom separator logic. Plural selection is
unchanged: i18next still picks the plural form from the raw `count`.
- `src/i18n/locales.test.ts` fails if any locale adds a counter placeholder
(`count`, `current`, `total`, `missedCount`, `upcomingCount`) without the
formatter, and checks grouping for plural and non-plural counters in `en` and
`de`.
- `breeze ui check-translation-completeness` keeps treating `{{count,
number}}` as plural-driving.
- The `airflow-translations` skill tells translators to keep the `, number`
suffix.
</details>
---
##### Was generative AI tooling used to co-author this PR?
- [X] Yes — Claude Code (Opus 5.5)
Generated-by: Claude Code (Opus 5.5) following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
