potiuk commented on code in PR #74151: URL: https://github.com/apache/airflow/pull/74151#discussion_r4189236513
########## dev/breeze/src/airflow_breeze/global_constants.py: ########## @@ -527,7 +522,7 @@ def get_default_platform_machine() -> str: # All python versions include all past python versions available in previous branches # Even if we remove them from the main version. This is needed to make sure we can cherry-pick # changes from main to the previous branch. -ALL_PYTHON_MAJOR_MINOR_VERSIONS = ["3.10", "3.11", "3.12", "3.13", "3.14"] +ALL_PYTHON_MAJOR_MINOR_VERSIONS = ["3.11", "3.12", "3.13", "3.14"] Review Comment: The comment no longer matches the code. How about this, so the next version drop has the rule written down: ```suggestion # Python versions that CI on main builds images for and tests with. # # When main drops a Python version, the version goes through two phases here: # 1. While we still cherry-pick changes from main to a release branch that supports that version # (e.g. v3-3-test), keep it in this list even though main no longer supports it. Changes made # on main are then still tested on that version before they are cherry-picked. # 2. Once we stop cherry-picking to the last release branch that supports it (that branch then only # gets fixes applied directly), remove it from this list. Release branches keep their own copy # of this list, so their CI and image builds are not affected. ALL_PYTHON_MAJOR_MINOR_VERSIONS = ["3.11", "3.12", "3.13", "3.14"] ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
