potiuk commented on code in PR #74157:
URL: https://github.com/apache/airflow/pull/74157#discussion_r4189368184


##########
task-sdk/src/airflow/sdk/api/datamodels/_generated.py:
##########
@@ -21,7 +21,7 @@
 from __future__ import annotations
 
 from datetime import timedelta
-from enum import Enum
+from enum import StrEnum

Review Comment:
   Bumping the codegen `target-python-version` to 3.11 makes datamodel-codegen 
emit `StrEnum` for 8 Task SDK enums and about 22 in airflowctl, including 
`DagRunState`. That's the change this PR deliberately avoids by ignoring UP042 
(`f"{X.A}"` becomes `"a"` instead of `"X.A"`). It may well be fine for 
generated wire models, but it should be a deliberate, documented choice. 
Otherwise keep the codegen target at 3.10 so this layer stays mechanical.



##########
dev/breeze/uv.lock:
##########
@@ -1481,14 +1393,11 @@ wheels = [
 
 [[package]]
 name = "pyjwt"
-version = "2.15.0"
+version = "2.14.0"

Review Comment:
   The Breeze lock regeneration downgrades recently bumped packages: pyjwt 
2.15.0 → 2.14.0 (reverting #73969), prek 0.5.4 → 0.5.3, boto3/botocore 1.43.103 
→ 1.43.100, filelock 4.0.5 → 4.0.1. Probably `exclude-newer = "4 days"` in 
`dev/breeze/pyproject.toml` hiding the versions dependabot just locked. Could 
you relock so the existing pins stay and only `exceptiongroup`/`tomli` and 
friends drop out?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to