potiuk commented on code in PR #74153:
URL: https://github.com/apache/airflow/pull/74153#discussion_r4189367075
##########
task-sdk/tests/task_sdk/bases/test_operator.py:
##########
@@ -1219,7 +1203,6 @@ async def aexecute(self, context):
op.execute({})
[email protected]("event_loop_runner")
class TestEventLoop:
"""``event_loop()`` hands synchronous code a loop it owns, through
``asyncio.Runner`` where Python has it."""
Review Comment:
With the fallback gone, ``where Python has it`` no longer applies. Maybe end
the sentence at ``through ``asyncio.Runner``.``
##########
airflow-core/src/airflow/serialization/stub_arg_bindings.py:
##########
@@ -75,9 +75,8 @@ def _normalize_temporal_annotation(annotation: Any) -> Any:
Applied recursively through unions and containers, and only as a retry
when direct
schema generation fails, so temporal types carrying their own pydantic
schema keep it.
"""
- # Parametrized generics must be detected before the plain-class branch: on
Python
- # 3.10, isinstance(list[X], type) is True and issubclass silently consults
the
- # origin, so the class branch would return list[X] unnormalized.
+ # Parametrized generics must be detected before the plain-class branch so
the
+ # class branch never returns list[X] unnormalized.
Review Comment:
On 3.11+ `isinstance(list[X], type)` is False, so the class branch can't
catch `list[X]` anyway and the ordering is no longer load-bearing. Drop the
comment, or say that the generic branch is the one that recurses into args?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
