zach-overflow commented on code in PR #73116:
URL: https://github.com/apache/airflow/pull/73116#discussion_r4189386805


##########
task-sdk/pyproject.toml:
##########
@@ -53,8 +53,10 @@ dependencies = [
     "asgiref>=3.11.1; python_version >= '3.14'",
     "attrs>=24.2.0, !=25.2.0",
     "babel>=2.17.0",
+    # Direct import in airflow.sdk.api.client; used to arrive via httpx, but 
httpx2 uses truststore.
+    "certifi>=2024.7.4",

Review Comment:
   Good question, and I don't believe this was discussed in prior threads on 
this PR. Let me double check that we can do a simple swap with the `certifi` 
call(s) in `task-sdk/src/airflow/sdk/api/client.py` and update accordingly if 
possible. From the [official "migrating from httpx" 
docs](https://pydantic.dev/docs/httpx2/get-started/migration/#behavior-differences),
 they do mention this change, and I agree with their assessment that it should 
really only simplify things by using `truststore` over `ceritifi`. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to