ferruzzi commented on code in PR #74125:
URL: https://github.com/apache/airflow/pull/74125#discussion_r4190716458
##########
providers/amazon/src/airflow/providers/amazon/aws/waiters/comprehend.json:
##########
@@ -99,6 +99,55 @@
"state": "success"
}
]
+ },
+ "document_classifier_deletable": {
+ "delay": 10,
+ "maxAttempts": 30,
+ "operation": "DescribeDocumentClassifier",
+ "acceptors": [
+ {
+ "matcher": "path",
+ "argument": "DocumentClassifierProperties.Status",
+ "expected": "SUBMITTED",
+ "state": "retry"
+ },
+ {
+ "matcher": "path",
+ "argument": "DocumentClassifierProperties.Status",
+ "expected": "TRAINING",
+ "state": "retry"
+ },
+ {
+ "matcher": "path",
+ "argument": "DocumentClassifierProperties.Status",
+ "expected": "STOP_REQUESTED",
+ "state": "retry"
+ },
+ {
+ "matcher": "path",
+ "argument": "DocumentClassifierProperties.Status",
+ "expected": "TRAINED",
+ "state": "success"
+ },
+ {
+ "matcher": "path",
+ "argument": "DocumentClassifierProperties.Status",
+ "expected": "TRAINED_WITH_WARNING",
+ "state": "success"
+ },
+ {
+ "matcher": "path",
+ "argument": "DocumentClassifierProperties.Status",
+ "expected": "IN_ERROR",
+ "state": "success"
+ },
+ {
+ "matcher": "path",
+ "argument": "DocumentClassifierProperties.Status",
+ "expected": "STOPPED",
+ "state": "success"
+ }
+ ]
Review Comment:
It wasn't included because the teardown skips that status before it ever
calls the waiter, but you're right that it probably should be here for
completeness sake. A DELETING classifier can never become deletable, so it's a
failing state. I'll add it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
