FrankYang0529 opened a new pull request, #74319: URL: https://github.com/apache/airflow/pull/74319
Implement [Go SDK: Serialize a native Dag to Dag JSON](https://github.com/orgs/apache/projects/499/views/7?pane=issue&itemId=248987212). - `DagRef.serialize` writes `{"__version": 3, "dag": {...}}` for a registered Dag. The `dag` object holds the timetable, the tasks, the edge labels and a `dag_dependencies` entry for each `TriggerDagRun` task. The task groups form a tree, written as `children[label] = [kind, value]`, and each group records its group edges. - A `TriggerDagRun` task gets the fields that Python writes for a `TriggerDagRunOperator`. The `TriggerDagRun` task also carries the other parameters, such as `poke_interval`. An unset `LogicalDate` is written as `NOTSET`. - A table in `serialize.go` maps each field of `DagSpec`, `TaskSpec` and `TaskGroupSpec` to its schema property. A field that is unset or at its schema default is left out. - When a Dag leaves `max_active_runs` and four other fields unset, Python takes their values from the Airflow config. A bundle cannot read that config, so the serializer leaves the five fields out. Airflow core fills them in from the config when it receives the serialized Dag. - `DagSpec` has a new `Queue` field, because the Go SDK has no `default_args` to give every task a queue. A Go task runs on the queue that `DagSpec.Queue` names, unless its `TaskSpec` sets a `Queue`. A `TriggerDagRun` task does not take the Dag's `Queue`, because a Python worker runs the task. - Each number in `TriggerDagRunSpec.Conf` used to be copied as a `json.Number`, and is now copied as an `int64`, a `uint64` or a `float64`. A bundle sends the serialized Dag to Airflow as msgpack, which writes a `json.Number` as a string. An integer that fits in neither 64-bit integer type is rejected. <!-- SPDX-License-Identifier: Apache-2.0 https://www.apache.org/licenses/LICENSE-2.0 --> <!-- Thank you for contributing! Please provide above a brief description of the changes made in this pull request. Write a good git commit message following this guide: https://chris.beams.io/posts/git-commit/ Please make sure that your code changes are covered with tests. And in case of new features or big changes remember to adjust the documentation. For user-facing UI changes, please attach before/after screenshots (or a short screen recording) so reviewers can assess the visual impact. Feel free to ping (in general) for the review if you do not see reaction for a few days (72 Hours is the minimum reaction time you can expect from volunteers) - we sometimes miss notifications. In case of an existing issue, reference it using one of the following: * closes: #ISSUE * related: #ISSUE --> --- ##### Was generative AI tooling used to co-author this PR? <!-- If generative AI tooling has been used in the process of authoring this PR, please change below checkbox to `[X]` followed by the name of the tool, uncomment the "Generated-by". --> - [X] Yes - Claude Code <!-- Generated-by: [Tool Name] following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions) --> --- * Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. Note: commit author/co-author name and email in commits become permanently public when merged. * For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed. * When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). * For significant user-facing changes create newsfragment: `{pr_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments). You can add this file in a follow-up commit after the PR is created so you know the PR number. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
