kaxil opened a new pull request, #74359: URL: https://github.com/apache/airflow/pull/74359
Removes 28 provider unit tests that assert a class attribute equals a copy of its own value, plus two skipped placeholders. Most of them restate a whole `template_fields` tuple or `template_fields_renderers` dict, or list every field of the tuple one `in` check at a time. They fail on every intentional edit to the tuple, so the author updates the test in the same diff and it ends up checking whatever the diff says. The property worth checking, that every template field is set as an attribute in `__init__`, is already enforced by the `check-template-fields-valid` prek hook. The pattern also gets copied into each new operator PR (most recently #70930). The other four are display-only `hook_name` assertions (`"Azure" in PydanticAIAzureHook.hook_name`). Kept on purpose: - Single-field guards that pin a decision someone could undo by accident: `"budget" in ...`, `"client_request_token" not in ...`, `query_tags`, `hook_params`, `documents` on the LlamaIndex embedding operator. - Subclass checks such as `LLMBranchOperator.template_fields` containing every `LLMOperator` field. - `conn_type`, `default_conn_name` and `conn_name_attr` pins. Nothing else checks that a hook's `conn_type` matches its `provider.yaml` entry; `ProvidersManager` only logs an "Inconsistency!" warning. The two placeholders: - `TestLivyDbHook.test_missing_host` has been skipped since 2022 because `HttpHook` never raised for a missing host. - `TestPostgresHookPPG3.test_get_all_db_log_messages` is a skipped `pass`. The shared base class has no test of that name, so removing it does not re-enable anything. --- * Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. Note: commit author/co-author name and email in commits become permanently public when merged. * For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed. * When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). * For significant user-facing changes create newsfragment: `{pr_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments). You can add this file in a follow-up commit after the PR is created so you know the PR number. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
