kaxil opened a new pull request, #74362: URL: https://github.com/apache/airflow/pull/74362
Removes 83 Google hook tests that duplicate a test in a sibling class, along with the 11 classes left empty, about 1,860 lines in all. Several Google hook test modules have a `...WithDefaultProjectIdHook` class and a `...WithoutDefaultProjectIdHook` class whose setups differ only in the mocked `GoogleBaseHook.__init__`. Each removed test is AST-identical to a test in the `With` class and passes an explicit `project_id`. With an explicit project id, `fallback_to_default_project_id` never reads the hook's default, so both copies run the same code path. The `With` copy passes `TEST_PROJECT_ID = "test-project-id"` against a mocked default of `"example-project"`, so it already shows that the explicit id wins. Every `Without` test that omits `project_id`, expects a raise, or has no identical twin stays. Those are the tests that cover the no-default path. Modules whose setups differ in more than the mock (`test_bigtable.py`, `test_compute.py`, `test_functions.py`) are untouched. --- * Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. Note: commit author/co-author name and email in commits become permanently public when merged. * For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed. * When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). * For significant user-facing changes create newsfragment: `{pr_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments). You can add this file in a follow-up commit after the PR is created so you know the PR number. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
