Andrushika commented on code in PR #74390:
URL: https://github.com/apache/airflow/pull/74390#discussion_r4203361021
##########
airflow-core/src/airflow/ti_deps/deps/not_previously_skipped_dep.py:
##########
@@ -177,8 +177,9 @@ def _mapped_group_skip_decisions(
query = XComModel.get_many(
run_id=ti.run_id, key=XCOM_SKIPMIXIN_KEY, dag_ids=ti.dag_id,
task_ids=skipmixin_task_ids
)
+ entity = xcom_entity(query)
rows = session.execute(
- query.with_only_columns(XComModel.task_id, XComModel.map_index,
XComModel.value).order_by(None)
+ query.with_only_columns(entity.task_id, entity.map_index,
entity.value).order_by(None)
Review Comment:
I think this also fixes a bug, not only the lint. The old
`XComModel.<column>` dropped the filters from `get_many()`, so a skip decision
from another Dag run could skip the same map index in this run. Maybe the title
and description could say this, since they become the commit message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
