kaxil opened a new pull request, #74405:
URL: https://github.com/apache/airflow/pull/74405

   `check-xcom-model-columns` was added in #74222 with `requires-python = 
">=3.10"` in its inline script metadata. #74152 moved the other prek scripts to 
`>=3.11` but merged later the same day, so it missed this one, and it was the 
last `>=3.10` pin left in the repo. When prek resolves the hook to a Python 
3.10 interpreter (for example one it already has cached), `ast.parse` rejects 
the 3.11-only star-unpacking subscripts now on main, such as 
`Result[*tuple[...]]` from #74154. The hook then fails on four files that never 
touch XCom:
   
   ```
   airflow-core/src/airflow/api_fastapi/core_api/routes/public/assets.py:216: 
could not parse: invalid syntax
   airflow-core/src/airflow/api_fastapi/core_api/routes/public/dag_stats.py:78: 
could not parse: invalid syntax
   airflow-core/src/airflow/api_fastapi/auth/managers/base_auth_manager.py:720: 
could not parse: invalid syntax. Perhaps you forgot a comma?
   airflow-core/src/airflow/dag_processing/collection.py:710: could not parse: 
invalid syntax
   ```
   
   The hook passes in CI, so this only shows up in local runs. With the bump, 
`prek run check-xcom-model-columns --all-files` passes.
   
   ---
   
   * Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
 for more information. Note: commit author/co-author name and email in commits 
become permanently public when merged.
   * For fundamental code changes, an Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
 is needed.
   * When adding dependency, check compliance with the [ASF 3rd Party License 
Policy](https://www.apache.org/legal/resolved.html#category-x).
   * For significant user-facing changes create newsfragment: 
`{pr_number}.significant.rst`, in 
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
 You can add this file in a follow-up commit after the PR is created so you 
know the PR number.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to