harshitsaxena214 commented on issue #74414: URL: https://github.com/apache/airflow/issues/74414#issuecomment-6045220291
Hi @jason810496, I'd like to work on this one. Could you assign it to me? My plan: - **Types:** add `logicalDate?: Date | null` and `runAfter?: Date` to `TriggerDagRunSpec`. Omitting `logicalDate` keeps today's behavior (current time), `null` means no logical date, and `runAfter` is only sent when set. - **Runner:** update `trigger-runner.ts` to follow `TriggerDagRunOperator.execute`. That means ISO-serializing both values, sending `run_after` only when present, and building `run_id` as `manual__<isoformat(run_after or logical_date)>`, with a random 8-char suffix when there's no logical date. No Jinja rendering, per ADR-0008. - **Tests:** cover the default (unchanged) behavior, `logicalDate` as a date, `null` and omitted, `runAfter` set and unset, and the `run_id` rules for each combination. - **Docs:** update the doc comments and SDK docs with the example from the issue. I'll also compare against the Go SDK runner so the two stay consistent. Happy to adjust anything once I'm assigned and start the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
