yuseok89 opened a new pull request, #74434:
URL: https://github.com/apache/airflow/pull/74434
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
https://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
For user-facing UI changes, please attach before/after screenshots (or a
short
screen recording) so reviewers can assess the visual impact.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
closes: #40209
related: #71922
`HttpSensor(deferrable=True)` with a `response_check` falls back to the
synchronous poke loop and holds a worker slot for the whole wait. It now
defers, and the check runs on the worker after the trigger returns. If the
check returns `False`, the task defers again.
Unlike #44557 and #47719, nothing is pickled and the callable never leaves
the worker. The trigger returns the response through the existing JSON-based
`HttpResponseSerializer`, and re-deferring follows `S3KeySensor` with
`check_fn`.
`HttpSensorTrigger` gets an `initial_delay` so that a re-deferred trigger
waits `poke_interval` before its first request. Each deferral also passes the
remaining sensor timeout, so `timeout` still applies overall.
## Verified with a live Dag
An `HttpSensor(deferrable=True, poke_interval=20)` with a `response_check`
that passes two minutes after the run starts. Before the change the task stayed
`running`. After the change it defers, rechecks every 20 seconds, and succeeds
once the check passes.
<img width="996" height="444" alt="image"
src="https://github.com/user-attachments/assets/47293540-61f3-4478-a3b4-af12f149522d";
/>
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [x] Yes (please specify the tool below)
- Claude Code (Opus 5.5)
<!--
Generated-by: [Tool Name] following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
