uranusjr commented on code in PR #74096:
URL: https://github.com/apache/airflow/pull/74096#discussion_r4214871735
##########
java-sdk/plugin/src/main/kotlin/org/apache/airflow/sdk/plugin/AirflowSdkPlugin.kt:
##########
@@ -63,6 +65,9 @@ abstract class AirflowBundleExtension {
abstract val fatJar: Property<Boolean>
}
+/** The JAR tasks a deployable bundle is assembled from, fat or thin. */
+private val BUNDLE_JAR_TASKS = setOf("jar", "shadowJar")
Review Comment:
This duplicates the decision the bundle task already makes. The two can
drift, and a user building the bundle from a custom jar task can't get the
payload.
Wire the payload onto the jar task consumed by the bundle task, in the same
`if (ext.fatJar.get())` branch instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
