ephraimbuddy commented on code in PR #73327:
URL: https://github.com/apache/airflow/pull/73327#discussion_r4229002262
##########
airflow-core/src/airflow/dag_processing/manager.py:
##########
@@ -304,7 +294,7 @@ class DagFileProcessorManager(LoggingMixin):
)
"""Resolved once per process so file discovery and the deactivation scan
use the same value."""
- _api_server: InProcessExecutionAPI = attrs.field(init=False,
factory=_make_execution_api)
+ _api_server: InProcessExecutionAPI = attrs.field(init=False,
factory=InProcessExecutionAPI)
Review Comment:
`create_task_execution_api_app()` creates the app, but the manager also
needs a way for its client to send requests to it without an HTTP server, plus
authentication setup for those local requests. using `InProcessExecutionAPI`
provides that setup and delays creating the app until needed. Calling the
factory directly would mean implementing those pieces again in the manager.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
