firasbouzazi commented on PR #74198: URL: https://github.com/apache/airflow/pull/74198#issuecomment-6110029225
> Thanks, the hyphen change looks good. > > I filled two of the untested paths on a real workspace (AWS), calling `system.ai.dbsql` with this branch merged onto `main`: > > * **Successful tool call:** `execute_sql` with `SELECT 1` returned `SUCCEEDED` with the row, with a personal OAuth token as the connection password. > * **Service principal OAuth:** with a new service principal (`service_principal_oauth`, client ID and secret only), the toolset connected and listed tools. The secret never appeared in the output. > > * Before the service principal had `CAN_USE` on a warehouse, `execute_sql` came back as `ModelRetry: Managed MCP SQL failed: ... NOT_FOUND: No usable warehouses found`. After the grant it returned `SUCCEEDED`. This also shows the call ran as the service principal: my own user can use that warehouse. > > Azure AD is still untested. > > On `init_timeout`: +1 to adding it in this PR. Without it, a service in front of a slow upstream fails at the handshake every time, and the user can do nothing about it. Reporting the timeout as `DatabricksUnityMCPTransportError` fits the existing error table. > > Drafted-by: Claude Code (Opus 5.5); reviewed by @moomindani before posting Okay thanks for the feedback and the tests I will also be waiting for @zozo123 feedback. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
