Autumn2OO5 opened a new pull request, #74565: URL: https://github.com/apache/airflow/pull/74565
When `triggerer.keda.enabled` is `false` but `triggerer.keda.namespaceLabels` is set, the PgBouncer NetworkPolicy still uses those labels for its KEDA ingress peer. If worker KEDA is enabled without `namespaceLabels`, the expected same-namespace `keda-operator` peer is replaced by a `namespaceSelector` taken from the disabled triggerer KEDA. A KEDA operator in the release namespace without those labels can then no longer reach PgBouncer. The template already computes `$triggererKedaEnabled` (triggerer enabled **and** triggerer KEDA enabled), but the namespace-label branch checked only `.Values.triggerer.enabled`. It now uses `$triggererKedaEnabled`, so labels for a disabled feature no longer affect the rendered policy. Behaviour when triggerer KEDA is enabled, or when worker KEDA sets its own `namespaceLabels`, is unchanged. A test case covers worker KEDA enabled with triggerer KEDA disabled but carrying `namespaceLabels`; it fails without the fix. Checks run locally: - `uv run --project chart pytest chart/tests/helm_tests/other/test_pgbouncer.py::TestPgbouncerNetworkPolicy`: 20 passed - `helm lint chart`: passed - prek hooks: passed, with the breeze-based hooks skipped (`SKIP_BREEZE_PREK_HOOKS`), so `lint-helm-chart` and `kubeconform` were not run locally - The breeze Helm test suite (`breeze testing helm-tests`) was not run locally closes: #74546 --- ##### Was generative AI tooling used to co-author this PR? <!-- If generative AI tooling has been used in the process of authoring this PR, please change below checkbox to `[X]` followed by the name of the tool, uncomment the "Generated-by". --> - [X] Yes (please specify the tool below) Generated-by: Claude Code (Opus 5.5) following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions) --- * Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. Note: commit author/co-author name and email in commits become permanently public when merged. * For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed. * When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). * For significant user-facing changes create newsfragment: `{pr_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments). You can add this file in a follow-up commit after the PR is created so you know the PR number. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
