kaxil commented on PR #71592:
URL: https://github.com/apache/airflow/pull/71592#issuecomment-6152950334
Thanks, LGTM. Could you update the title and description before merge? They
still describe the earlier `render_template_as_native()` plus `str()` approach,
but the code now renders the label with the Dag's sandboxed string environment.
A title like "Fix map_index_template failing for numeric-looking labels with
render_template_as_native_obj" reads better in the changelog.
One user-visible change is worth a line in the description: on Dags with
`render_template_as_native_obj=True`, a quoted template such as `"'{{
ti.try_number }}'"` (the workaround suggested on #71586) now shows the quotes
in the label, the same as on default Dags.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
