kaxil commented on PR #70961: URL: https://github.com/apache/airflow/pull/70961#issuecomment-6158241562
Both points from the last round are in: the DELETE re-checks all three referrers, and each `clean_unused()` call now deletes at most one batch. LGTM. Two non-blocking notes: - The `batch_size <= 0` check runs inside `run_once` after `load_triggers()` has already claimed triggers. A value of 0 reads like "no batching" (that is how `[state_store] state_cleanup_batch_size` defines it), and here it crash-loops the triggerer, leaving its claimed triggers orphaned until the health check threshold passes. Validating it in `TriggererJobRunner.__init__` next to `capacity` would fail before any DB work. - #68243 describes the scheduler side as already fixed, but #68241 was closed unmerged. `SchedulerJobRunner._remove_unreferenced_triggers` still deletes the whole backlog in one statement every `parsing_cleanup_interval` (60s by default). That deserves a follow-up, and the follow-up should decide whether it reuses this option or gets its own `[scheduler]` one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
