SEPURI-SAI-KRISHNA commented on PR #74181: URL: https://github.com/apache/airflow/pull/74181#issuecomment-6165134328
Gentle ping on this one. It has been open ten days with CI green, 43 checks passing and none failing. No reviewer was auto-assigned, and I think that is why it has been quiet rather than anything about the change: `.github/CODEOWNERS` has entries for `airflow-core/src/airflow/executors/`, `jobs/`, `models/`, `serialization/` and `dag_processing`, but none that covers `airflow-core/src/airflow/state/`, so nobody was notified when it was opened. For context on what it does: `task_state_store.set(key, value, retention=timedelta(hours=6))` is documented as making the key expire, and it does not. `expires_at` is written on every path and read on none, so `get()` keeps returning the value indefinitely, and the cleanup command is documented as manual and never scheduled by Airflow. The change adds the expiry predicate to the two read paths and leaves the delete and cleanup queries alone, since those exist to find expired rows. Happy to rebase or split it if that would help. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
