Eason09053360 commented on code in PR #74786:
URL: https://github.com/apache/airflow/pull/74786#discussion_r4281918149
##########
providers/google/tests/system/google/cloud/composer/example_cloud_composer.py:
##########
@@ -310,7 +310,7 @@ def cleanup_failed_environment_before_retry(context:
dict[str, Any]) -> None:
composer_external_dag_id="airflow_monitoring",
composer_external_task_id="echo",
allowed_states=["success"],
- execution_range=timedelta(days=1),
+ execution_range=[datetime.now() - timedelta(1), datetime.now()],
Review Comment:
Non-blocking, and it predates this PR: `datetime.now()` is naive local time,
but the poke sensor sends it to the API with a `Z` suffix. On a UTC-7 worker
the window ends 7h ago and misses the triggered run.
`datetime.now(tz=timezone.utc)` would make this docs snippet safe to copy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
