sahilSENPAII opened a new pull request, #74816:
URL: https://github.com/apache/airflow/pull/74816
closes: #74814
### Problem
`GET /api/v2/assets/events?name_prefix_pattern=~` returns each asset event
once per asset in the
table. With two assets and one event each, the response contains every event
twice and reports
`total_entries: 4` instead of `2`. An empty `name_pattern=` takes the same
path.
### Cause
`~` is the documented "match all" alias for `name_prefix_pattern` and is
transformed into an empty
string. `get_asset_events` joins `AssetModel` only when a name filter value
is truthy, so the join is
skipped for `""`. The filter itself is still applied, because it skips only
`None`, and it adds a
predicate on `asset.name` without a join condition. The query becomes a
cartesian product of `asset`
and `asset_event`. The truthiness check was extended to
`name_prefix_pattern` in #64963.
### Fix
Join `AssetModel` whenever either name filter value is not `None`, which
matches when the filters
themselves are applied.
### Testing
- Added `({"name_prefix_pattern": "~"}, 2)` and `({"name_pattern": ""}, 2)`
to
`TestGetAssetEvents.test_filtering`. Both fail without the fix (SQLAlchemy
raises its
cartesian-product `SAWarning`; with the warning ignored, `total_entries`
is 4 instead of 2) and
pass with it.
- `test_assets.py`: 218 passed.
- prek passes on both files. `generate-openapi-spec` and
`check-tests-in-the-right-folders` were
skipped locally since they need Breeze; the API schema is unchanged.
---
##### Was generative AI tooling used to co-author this PR?
- [X] Yes (please specify the tool below)
Generated-by: Claude Code following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
