NabiBukhsh-AI commented on code in PR #74561:
URL: https://github.com/apache/airflow/pull/74561#discussion_r4298676888
##########
providers/amazon/src/airflow/providers/amazon/aws/hooks/appflow.py:
##########
@@ -80,11 +80,21 @@ def run_flow(
return execution_id
- def _log_execution_description(self, flow_name: str, execution_id: str):
- response_desc =
self.conn.describe_flow_execution_records(flowName=flow_name)
- last_execs = {fe["executionId"]: fe for fe in
response_desc["flowExecutions"]}
- exec_details = last_execs[execution_id]
- self.log.info("Run complete, execution details: %s", exec_details)
+ def _log_execution_description(self, flow_name: str, execution_id: str) ->
None:
+ args: dict[str, Any] = {"flowName": flow_name, "maxResults": 100}
+ while True:
Review Comment:
Good catch, thank you! Added the escape hatch `or next_token ==
args.get("nextToken")` and added a unit test (`test_run_flow_repeating_token`)
to verify it breaks cleanly if the service returns an identical token.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
