shivaam commented on code in PR #74623: URL: https://github.com/apache/airflow/pull/74623#discussion_r4304450331
########## providers/smtp/docs/utils/legacy.rst: ########## Review Comment: Agreed, reworked it that way. The PR now copies `airflow/utils/email.py` into `airflow.providers.smtp.utils.emailer` and drops the transport-only `legacy` module. The only code differences from core are the imports (through `common.compat`) and the Connection lookup, which uses `BaseHook.get_connection` instead of importing `airflow.models`. Once a provider release includes it, I'll open the core PR that deprecates `airflow.utils.email` and delegates to the provider, with the minimum SMTP provider version checked in core. ########## providers/smtp/src/airflow/providers/smtp/utils/legacy.py: ########## @@ -0,0 +1,88 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +"""Transport compatibility for callers that resolve legacy email settings.""" + +from __future__ import annotations + +import logging +import smtplib +from typing import TYPE_CHECKING + +if TYPE_CHECKING: + import ssl + from collections.abc import Callable + from email.mime.multipart import MIMEMultipart + +log = logging.getLogger(__name__) + + +def send_mime_email( Review Comment: Not today: the SMTP provider has no `utils` package on main. `SmtpHook` has similar private helpers, but it reads host, port and TLS from the Connection and retries failed sends, while the core functions read the `[smtp]` config section and only take the login and password from the Connection. Pointing core at the hook would change behavior for existing setups, so this copies the core module as is. Sharing the MIME helpers between the hook and this module can be a follow-up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
