dheerajturaga opened a new pull request, #75036: URL: https://github.com/apache/airflow/pull/75036
### Stack Stacks on #75035. Stack index: 4 of 20. A PR from a fork cannot target a fork branch, so each PR in the stack is based on `main` and contains every commit below it; only the top commit is new. Review only the commit "AIP-125: Add WebhookSource base classes"; the commits below it belong to earlier PRs in the stack. ### Status Draft. [AIP-125 (Inbound Webhooks)](https://lists.apache.org/thread/p3dpnor4zwko8tldpncj6ftj1bpp18q7) is under discussion on dev@ and not yet voted; this stack is its proof of concept so that voters can run it, and nothing should merge before the vote. The feature is opt-in (only `airflow api-server --apps webhooks` serves deliveries) and experimental; no unauthenticated route is reachable until stack PR 18, which merges last. ### Why Every sender signs and shapes its webhook deliveries in its own way, so providers will ship source types that verify and parse them, while naming, lookup and recording stay in core. This adds the experimental contract those source types code against, `airflow.webhooks.base`, with the signature and JSON helpers from the proof-of-concept provider. Nothing calls it yet. ### What to look at - The contract: `from_extra`, `verify`, `parse`, optional `is_handshake` and `handshake` with the `unsigned_handshake` flag, `summarize` and `default_store_payload`. Any exception from `verify` is a 401, a `ValueError` from `parse` or `handshake` a 400, anything else a 500. - `WebhookDelivery` carries `path` and `kinds`, from which core builds names, flat `attributes` (strings or integers, for Phase 2 matching), `delivery_id`, `correlation_key` and `payload`. - `load_json_object` refuses what a database cannot store: NaN, Infinity, floats too large, U+0000, unpaired surrogates, and nesting deeper than 64 levels. - `verify_hmac_sha256` and `verify_token` refuse an empty secret and compare in constant time. ### Testing - `test_base.py` passed under breeze on SQLite, Postgres and MySQL. After the last fixes, the tests were rerun on SQLite and Postgres, and the final head passed again on MySQL. - breeze's `test_pytest_args_for_test_types.py`, which gains the `webhooks` test folder, passed on the host. --- ##### Was generative AI tooling used to co-author this PR? - [X] Yes — Claude Code (Opus 5.5) Generated-by: Claude Code (Opus 5.5) following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions) --- * Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. Note: commit author/co-author name and email in commits become permanently public when merged. * For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed. * When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). * For significant user-facing changes create newsfragment: `{pr_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments). You can add this file in a follow-up commit after the PR is created so you know the PR number. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
