Andrushika commented on PR #73964:
URL: https://github.com/apache/airflow/pull/73964#issuecomment-6260069567
Thanks for the careful review! Updated in ddaae391b1:
1. Docs now only say `down` and `doctor` keep the build cache volume. They
also say that commands like `breeze shell --restart` still remove it with the
other volumes. I kept the shared `bring_compose_project_down()` as it is.
`breeze run` and the registry commands start a one-off project with a unique
name and bring it down in `finally`. If that teardown kept the cache, every run
would leave a new `<project>_airflow-cache-volume` behind that nothing uses
again.
2. I changed the docs to match the code: without `--preserve-volumes`, build
cache volumes of deleted worktrees are removed. This follows the `-p` help
("Keep all volumes, including those belonging to deleted worktrees"). The
preserve/cleanup decision is now one helper, `_should_remove_volume`, and the
early `continue` is gone.
Smaller ones:
- `--cleanup-build-cache` help now says it only covers the projects being
brought down.
- About the bare `airflow-cache-volume`: I think no tooling ever created a
volume with that exact name. `git log -S` shows only #48740 used it, as a
compose volume key without `name:`, so Docker always created
`<project>_airflow-cache-volume`. The old `docker volume rm
airflow-cache-volume` removed nothing, which is the bug this PR fixes. Happy to
add the old removal back if you know of a case that created it.
- `doctor` now asks the cache question first and brings the projects down
once.
- `BUILD_CACHE_VOLUME` moved to `utils/path_utils.py`.
---
Drafted-by: Claude Code (Opus 5.5); reviewed by @Andrushika before posting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
