dheerajturaga opened a new pull request, #75045: URL: https://github.com/apache/airflow/pull/75045
### Stack Stacks on #75044. Stack index: 13 of 20. A PR from a fork cannot target a fork branch, so each PR in the stack is based on `main` and contains every commit below it; only the top commit is new. Review only the commit "AIP-125: Add the webhook name grammar as a shared library"; the commits below it belong to earlier PRs in the stack. ### Status Draft. [AIP-125 (Inbound Webhooks)](https://lists.apache.org/thread/p3dpnor4zwko8tldpncj6ftj1bpp18q7) is under discussion on dev@ and not yet voted; this stack is its proof of concept so that voters can run it, and nothing should merge before the vote. The feature is opt-in (only `airflow api-server --apps webhooks` serves deliveries) and experimental; no unauthenticated route is reachable until stack PR 18, which merges last. ### Why Dags subscribe to deliveries by scheduling on topic names the API server derives from each delivery. The Task SDK's `WebhookTopic` and the API server must build those names with the same rules, or a topic silently stops matching, and core may not import the SDK. A shared distribution symlinked into both keeps one copy, which core's webhook name validation uses too; `airflow.webhooks.naming` re-exports it for source types. ### What to look at - Unlike the proof of concept, values outside ASCII are not folded into names. Folding let a branch such as `maín` offer the names of `main`, so anyone who could push any branch could start the Dags subscribed to the protected one. A non-ASCII kind segment now ends the kind, a non-ASCII path segment is offered only as `*`, and `build_topic_name` refuses non-ASCII parts. - Bounds: names over 1500 characters are not offered, and paths deeper than 32 segments are offered only under wildcards. - Packaging: the new workspace member, its symlinks, and its mypy hook in the selective-checks test expectations (no rule change). - `docs/conf.py`: AutoAPI does not follow the `_shared` symlinks, so the library joins `autoapi_dirs`. ### Testing - The shared tests (51) passed under breeze on SQLite, Postgres and MySQL; after the ASCII fix, all 57 passed under breeze on SQLite. `mypy-shared-webhook_naming` passed. - breeze's `test_selective_checks.py` passed on the host; `breeze build-docs` is clean. ### Known limitations - The golden cases are the proof of concept's synthetic ones; recorded deliveries come with its 0.2 release. --- ##### Was generative AI tooling used to co-author this PR? - [X] Yes — Claude Code (Opus 5.5) Generated-by: Claude Code (Opus 5.5) following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions) --- * Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. Note: commit author/co-author name and email in commits become permanently public when merged. * For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed. * When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). * For significant user-facing changes create newsfragment: `{pr_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments). You can add this file in a follow-up commit after the PR is created so you know the PR number. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
