Shawnsuun commented on code in PR #74383:
URL: https://github.com/apache/airflow/pull/74383#discussion_r4311084169
##########
airflow-ctl/src/airflowctl/ctl/cli_config.py:
##########
@@ -525,8 +525,9 @@ def __init__(self, file_path: str | Path | None = None):
]
# Datamodels whose generated bool flags follow the datamodel field
defaults instead of
# defaulting to False, so the CLI keeps the API semantics (e.g. a bare
``tasks clear``
- # must keep ``dry_run=True`` and preview instead of clearing).
- self.field_bool_default_datamodels = ["ClearTaskInstancesBody"]
+ # must keep ``dry_run=True`` and preview instead of clearing, and a
bare ``dags update``
+ # must not send ``is_paused=False`` and unpause the Dag).
+ self.field_bool_default_datamodels = ["ClearTaskInstancesBody",
"DAGPatchBody"]
Review Comment:
Agreed, done in 2c83ba4340. `_get_bool_arg_default()` now uses the field's
own default for every request-body datamodel, and the allowlist is gone. `pools
update` without `--include-deferred` no longer sends `include_deferred=False`,
with a test for it.
---
Drafted-by: GitHub Copilot (Claude Opus 5.5) (no human review before posting)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
